Supplemental SAD - #10
Merged
Merged
Conversation
added 5 commits
July 24, 2026 13:02
Owner
|
@jimmielin Thanks for this -- looks great a first glance. I will look at it in more detail and do a quick BAM test and compare with non-refactored version. |
fvitt
reviewed
Aug 6, 2026
| !------------------------------------------------------------------------ | ||
| subroutine aero_surf_area_dens(self, aero_props, types_list, ncol, nlev, beglev, endlev, & | ||
| relhum, pmid, temp, sad, reff, sfc, dm_aer) | ||
| relhum, pmid, temp, pi, sad, reff, sfc, dm_aer) |
Owner
There was a problem hiding this comment.
@jimmielin Is there a need to pass the constant pi through the interface?
Author
There was a problem hiding this comment.
Thanks for the question! Yes, I am trying to avoid introducing dependencies on host modules (e.g. physconst) so the abstract interface can be ported to other models in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also set
beglevbased on the old waccm cutoff (oldzero_aerosols...)I also threaded through
piinto aerosol_state so it does not depend onmo_constants, will be helpful for when we port to CAM-SIMA.I made
supplemental_surf_area_denschecknitrateands-organic, so the namelist option will still behave as usual.Regression tests running now. I think because the SAD order is rearranged for FMOZ it'll still have an answer difference, but it includes everything now.