New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Images with external urls are not loaded #83

Open

dkyeremeh wants to merge 2 commits into fuzhenn:master from dkyeremeh:master

dkyeremeh commented Sep 22, 2023

node-canvas was able to load images with external urls, but @resvg/resvg-js does not do so automatically.
This PR intends to close the gap

Preloads images with external urls before resvg renders the svg
Allows images to point to external svg images as well

dkyeremeh added 2 commits

September 22, 2023 13:41


          Added node-fetch package

259d235


          Add image loader

b468dd6

fuzhenn requested a review from yisibl

September 24, 2023 02:39

Collaborator

yisibl commented Sep 25, 2023

Thanks for your contribution, need to add test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet