feat(threads): delay thread start until init_task() has finished
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ROMemories
reviewed
Nov 14, 2024
ROMemories
reviewed
Nov 14, 2024
| @@ -49,6 +49,13 @@ pub mod macro_reexports { | |||
| pub use static_cell; | |||
| } | |||
|
|
|||
| #[doc(hidden)] | |||
| pub mod _events { | |||
There was a problem hiding this comment.
Suggested change
| pub mod _events { | |
| pub mod events { |
_foo means that it's unused, not that it is private or "not to be used by users"
| _ => panic!(r#"neither "riot-rs" nor "riot-rs-threads" found in dependencies!"#), | ||
| } | ||
| }; | ||
|
|
||
| let expanded = quote! { | ||
| #no_mangle_attr |
There was a problem hiding this comment.
Suggested change
| #no_mangle_attr | |
| #no_mangle_attr | |
| #[inline(always)] |
Not saying that I know better than the compiler, but maybe in this case it can be useful, so that it gets inlined inside the trampoline function?
| #[doc(hidden)] | ||
| pub mod _events { | ||
| use crate::sync::Event; | ||
| // this is set in `riot_rs_embassy::init_task()`` |
There was a problem hiding this comment.
Suggested change
| // this is set in `riot_rs_embassy::init_task()`` | |
| // this is set in `riot_rs_embassy::init_task()` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds infra to make threads wait for system initialization (
riot_rs_embassy::init_task()) to complete before starting.This makes some code easier, e.g.,
asynch::spawner()to be populatedembedded-testintegration (WIP) #361 tests can assume a set up systemBasically, it allows threads to assume a sane system state.
Issues/PRs references
See also #509.
Open Questions
Change checklist