Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nightly): convert make_static!() to (Const)StaticCell #405

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix(nightly): convert make_static!() to (Const)StaticCell #405

merged 4 commits into from
Sep 10, 2024

Conversation

kaspar030
Copy link
Collaborator

@kaspar030 kaspar030 commented Sep 10, 2024 •
edited
Loading

Description

Issues/PRs references

make_static!() doesn't work with newer compilers, anymore :(

Open Questions

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

ROMemories
ROMemories requested changes Sep 10, 2024
View reviewed changes
examples/embassy-http-server/src/main.rs Show resolved Hide resolved
examples/embassy-http-server/src/main.rs Outdated Show resolved Hide resolved
examples/embassy-usb-keyboard/src/main.rs Outdated Show resolved Hide resolved
src/riot-rs-embassy/src/arch/stm32/usb_synopsis_otg.rs Outdated Show resolved Hide resolved
src/riot-rs-embassy/src/lib.rs Outdated Show resolved Hide resolved
src/riot-rs-embassy/src/lib.rs Outdated Show resolved Hide resolved
src/riot-rs-threads/src/autostart_thread.rs Outdated Show resolved Hide resolved
elenaf9
elenaf9 reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we now also drop the #![feature(type_alias_impl_trait)? Iirc it was only needed for the make_static! macro.

@kaspar030
Copy link
Collaborator Author

Can we now also drop the #![feature(type_alias_impl_trait)? Iirc it was only needed for the make_static! macro.

Looks like!

@ROMemories ROMemories added this pull request to the merge queue Sep 10, 2024
Merged via the queue into future-proof-iot:main with commit 15e5c1a Sep 10, 2024
26 checks passed
@kaspar030 kaspar030 deleted the drop_make_static branch November 14, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaf9 elenaf9 elenaf9 left review comments

@ROMemories ROMemories ROMemories approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @elenaf9 @ROMemories