Open
Conversation
There was a problem hiding this comment.
Pull request overview
目標入力フォームで「寝る時刻／起きる時刻」を入力できない問題の解消を目的に、時刻入力UIを変更しつつ、目標表示文言の一部を整理するPRです。
Changes:
- 寝る/起きるの時刻入力を
type="time"から「時・分のselect」に変更 - プレビュー表示用の時刻フォーマット関数を追加
- 表示ラベル「勉強した時間」→「勉強時間」に変更
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/components/Goal/GoalInput.tsx | 時刻入力UIの変更、時刻パース/プレビュー整形の追加、保存payload生成の整理 |
| src/components/Goal/Goal.tsx | 目標表示ラベルの文言更新（勉強時間） |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div style={{ fontWeight: 600, fontSize: 11 }}> | ||
| 勉強した時間 | ||
| </div> | ||
| <div style={{ fontWeight: 600, fontSize: 11 }}>勉強時間</div> |
Comment on lines
+88
to
+90
| const hour = part === "hour" ? value : currentHour; | ||
| const minute = part === "minute" ? value : currentMinute; | ||
| next[index] = hour || minute ? `${hour}:${minute}` : ""; |
Comment on lines
+191
to
+206
| <span>:</span> | ||
| <select | ||
| value={selectedMinute} | ||
| onChange={(e) => | ||
| handleTimePartChange(i, "minute", e.target.value) | ||
| } | ||
| style={{ | ||
| flex: 1, | ||
| padding: ".5rem .75rem", | ||
| fontSize: "1rem", | ||
| borderRadius: 8, | ||
| border: "1px solid #ddd", | ||
| }} | ||
| > | ||
| <option value="">分</option> | ||
| {minuteSlots.map((minute) => ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
確認したこと
関連する issue
レビューして欲しいこと
UI差分