locking holofans up

[BrightNibbleston]

About the PR

removed holofans spawning anywhere other than chief engineers toolbelt. moved holofan recipe into a new tier 3 research and removed it from tier 2

Why / Balance

holo-fans are very powerful pieces of kit, and in my opinion they are more powerful than the advanced tools like jaws of life and experimental welder, because they remove any danger from air if used properly a majority of spacing issues become a very easy and quick fix as you can seal the wall and drag people in or stuff in and repair things very easily, making the inflatable walls and metal foam we do have mostly useless. so I gave only CE and locked it behind its own tier 3 science. it making it a much rarer tool worth creating conflict over, in the hopes that its used less, and when it is theres more thought into not losing it and possibly creating conflict about what science should research.

Technical details

removed holofans from the lockers spawn tables
used migration.yml to date and switch every holofan on maps to null
created a new tier 3 science for 5000 points with a requirement of advanced atmosphericsthat unlocks the holofan recipe which was previously under advanced atmospherics. it is called "Hard-Light Gas Filter" and the id is "HolofanResearch" in the industrial.yml file. the image for advanced atmospherics is now a scrubber, the image for Hard-Light Gas Filter is a holofan

Media

no media other than the holofan

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an in-game showcase.
• If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

Breaking changes

according to what ive been told on the syndicate it may make maps fail tests until they are saved after merging this pr.

Changelog

🆑

• remove: Removed Holo-fan from everywhere except CE's tool belt!
• remove: Removed Holo-fan from advanced atmospherics research!
• add: Added new Hard-Light Gas Filter research!

[Terkala]

With this being tier 3, it means it competes with a lot of other very flashy T3 researches. It'll be a really hard sell to convince science that they want this over something like Bags of Holding or Microreactors.

Also this essentially cripples atmospherics from being able to do much early in the round, as anything more complicated than Frezon usually requires spacing or carefully controlling atmosphere in a small chamber.

[jackel234]

With this being tier 3, it means it competes with a lot of other very flashy T3 researches. It'll be a really hard sell to convince science that they want this over something like Bags of Holding or Microreactors.

Also this essentially cripples atmospherics from being able to do much early in the round, as anything more complicated than Frezon usually requires spacing or carefully controlling atmosphere in a small chamber.

aren't bags of holding and microreactors both t3 industrial? additionally, unless something changed, can't you get all t3 researches of the same discipline? if so, this ultimately makes t3 industrial more of good choice than it already was, rather than having to compete

[BrightNibbleston]

With this being tier 3, it means it competes with a lot of other very flashy T3 researches. It'll be a really hard sell to convince science that they want this over something like Bags of Holding or Microreactors.

Also this essentially cripples atmospherics from being able to do much early in the round, as anything more complicated than Frezon usually requires spacing or carefully controlling atmosphere in a small chamber.

That is part of the intended purpose, it makes industrial more valuable to go into while also creating a new source of conflict between departments. Funky also doesnt need holo fans for its atmospherics stuff because we have multiple ways to produce gasses you would normaly use a chamber for such as trit, along with multiple ways to empty and adjust pipes without spreading gas everywhere. Holo fans are a signifigant help which is why i left one with the chief engineer one within their belt, so if they wish they can give it to someone or put it down themselves for someone else making them more valuable

[Cadunkus]

Personally I'd much rather this not get merged. Let me explain

1. Holofans are temporary and can be walked through. They don't compete with inflatable walls or metal foam because they don't serve the same purpose. In repairs they're supposed to temporarily plug a hole in the hull to give time to apply a more permanent fix (like an inflatable wall) and metal foam nades are best saved for massive explosions. In non-repair uses they're also ideal to keep artifact and other atmos chambers from spilling out when you need to enter them so this also hurts science.
2. Industrial Tier 3 is already a strong contender for the best tier 3 tech (speed boots are fun but without microreactors aren't practical, temperature gun is only used on warops, and nobody ever uses the inverter thing) and doesn't need a buff.
3. Leave atmos alone. They get nerfed enough as is.

This change would have far more negative impact than positive.

[taydeo]

https://www.reddit.com/r/ss14/comments/1t7kzjf/my_opinions_on_atmos_drama_cwpolitical_cartoon/

reddit garbage found this pr and i havent even given a review or a comment on it yet

[BrightNibbleston]

With this being tier 3, it means it competes with a lot of other very flashy T3 researches. It'll be a really hard sell to convince science that they want this over something like Bags of Holding or Microreactors.

Also this essentially cripples atmospherics from being able to do much early in the round, as anything more complicated than Frezon usually requires spacing or carefully controlling atmosphere in a small chamber.

Oh, also forgot to mention in my previous reply i want chambers to be a more permenant decision as currently they are a place and rip down without a thought, however i think it would be much more beneficial to encourage testing with smaller amounts of gasses to understand how it works before scalling up production using a chamber

[BrightNibbleston]

Oops, missclicked, mb

[Cadunkus]

Ima be so real, im going to try and fail to take this seriously because of your 3rd point, "leave it alone, its fine as it is" is so silly in my opinion,

Am I wrong though? Atmos has a storied history of getting shafted by PRs far more than any other station job whether justified or not. Any suggested nerf to atmos is generally met with overwhelming negative reception at this point and I just can't see locking holofans behind tier 3 research being a positive change.

[pirakaplant]

Honestly I agree with the sentiment that this loads Industrial even more as the "meta" pick for Tier 3. However, maybe other stuff should be moved/removed because of this, as the holofan makes more sense than the bags of holding for Industrial (I think there was already discussion on making it Experimental), plus microreactors are literally just infinite batteries and kind of a balance problem.

I'd team up with @ThatOneMoon on this, given they were working on research restructuring in general.

[BrightNibbleston]

Oops, missclicked, mb

Ima be so real, im going to try and fail to take this seriously because of your 3rd point, "leave it alone, its fine as it is" is so silly in my opinion,

Am I wrong though? Atmos has a storied history of getting shafted by PRs far more than any other station job whether justified or not. Any suggested nerf to atmos is generally met with overwhelming negative reception at this point and I just can't see locking holofans behind tier 3 research being a positive change.

Yea that was an unfinished comment, i was trying to click out of it because i didont feel like going super into the issue, but you sre right about a lot of atmos things being taken away, but thats simply not a problem on funky, the main issue woth things being tsken away from atmos was a lack of other waya to do it, and on funky there is 2 other ways you can do what a holofan does, and i have listed several reasons about why it is positive, also just because it recieves a negative reception does not automatically mean its a bad idea or will have a negative impact

[BrightNibbleston]

Honestly I agree with the sentiment that this loads Industrial even more as the "meta" pick for Tier 3. However, maybe other stuff should be moved/removed because of this, as the holofan makes more sense than the bags of holding for Industrial (I think there was already discussion on making it Experimental), plus microreactors are literally just infinite batteries and kind of a balance problem.

I'd team up with @ThatOneMoon on this, given they were working on research restructuring in general.

I did think about moving some stuff around for better balance but i learnt they were doing a reatructure so i felt it would be much easier to just make the stuff so it can be moved easier and leave the restructuring to them because i am very bad at communication and it would work much better without me as i can get argumentative without realizing it and i believe they are going to make it a lot better than if i interfered

[corresp0nd]

its fine if we wanna make em more rare, cause i do agree that theyre a weird mechanic. the thing is that there's nothing really encouraging better options, so it kind of sucks to just make them this hard to get. id say keep the null migration and a ce toy, but keep them as t2 rather than t3

[BrightNibbleston]

its fine if we wanna make em more rare, cause i do agree that theyre a weird mechanic. the thing is that there's nothing really encouraging better options, so it kind of sucks to just make them this hard to get. id say keep the null migration and a ce toy, but keep them as t2 rather than t3

I will move them back to tier 2 but im going to put them into experimental because i feel like it belongs in experimental more than industrial

[TheHolyAegis]

YAML linter error:
::error in /Prototypes/Research/experimental.yml(135,6) Non-nullable field contained a null value

And IntegrationsTest failed:

Failed AllTechPrintableTest [195 ms]
  Error Message:
   Multiple failures or warnings in test:
  1)   Recipe 'WeaponForceGun' is dynamic on a lathe but cannot be unlocked by research.
Assert.That(unlockedTechs, Does.Contain(recipe))
  Expected: some item equal to WeaponForceGun
  But was:  < PowerCageRechargerCircuitboard, PowerCageSmall, PowerCageMedium, MagazineGrenadeEmpty, GrenadeFlash, GrenadeBlast, ShuttleGunSvalinnMachineGunCircuitboard, ShuttleGunPerforatorCircuitboard, ShuttleGunFriendshipCircuitboard, ClothingShoesBootsSpeed... >

And

2)   Recipe 'WeaponTetherGun' is dynamic on a lathe but cannot be unlocked by research.
Assert.That(unlockedTechs, Does.Contain(recipe))
  Expected: some item equal to WeaponTetherGun
  But was:  < PowerCageRechargerCircuitboard, PowerCageSmall, PowerCageMedium, MagazineGrenadeEmpty, GrenadeFlash, GrenadeBlast, ShuttleGunSvalinnMachineGunCircuitboard, ShuttleGunPerforatorCircuitboard, ShuttleGunFriendshipCircuitboard, ClothingShoesBootsSpeed... >