Skip to content

Admin log enhancement#83

Open
Terkala wants to merge 8 commits into
funky-station:masterfrom
Terkala:Admin_log_enhancement
Open

Admin log enhancement#83
Terkala wants to merge 8 commits into
funky-station:masterfrom
Terkala:Admin_log_enhancement

Conversation

@Terkala
Copy link
Copy Markdown
Contributor

@Terkala Terkala commented May 1, 2026

About the PR

Added several features admins had been asking for in the logs

Why / Balance

Reasons we discussed. Keeping admin discussion confidential because this is around player behavior logging.

Technical details

Lotta fancy log stuff

Media

Requirements

  • I have read and am following the Pull Request and Changelog Guidelines.
  • I have added media to this PR or it does not require an in-game showcase.
  • If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

Breaking changes

Changelog

@Terkala
Copy link
Copy Markdown
Contributor Author

Terkala commented May 1, 2026

Still debugging things, just putting a draft up while I identify all the other admin log features it should have

@Terkala Terkala marked this pull request as ready for review May 2, 2026 15:44
@Terkala
Copy link
Copy Markdown
Contributor Author

Terkala commented May 2, 2026

Ended up being much more extensive than originally intended, but should be really helpful

@Terkala
Copy link
Copy Markdown
Contributor Author

Terkala commented May 4, 2026

I do have one major concern: It does a lot of this log aggregation at end-of-round (to not introduce any midround lag). And I'm not actually sure how heavy of a DB hit it is at end-of-round, and don't really have a good way to model how laggy it could potentially be. It shouldn't interrupt gameplay, but at the absolute worse case it could lag out the end of round process.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@corresp0nd corresp0nd requested a review from taydeo May 18, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant