Admin log enhancement#83
Open
Terkala wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Still debugging things, just putting a draft up while I identify all the other admin log features it should have |
Contributor
Author
|
Ended up being much more extensive than originally intended, but should be really helpful |
Contributor
Author
|
I do have one major concern: It does a lot of this log aggregation at end-of-round (to not introduce any midround lag). And I'm not actually sure how heavy of a DB hit it is at end-of-round, and don't really have a good way to model how laggy it could potentially be. It shouldn't interrupt gameplay, but at the absolute worse case it could lag out the end of round process. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Added several features admins had been asking for in the logs
Why / Balance
Reasons we discussed. Keeping admin discussion confidential because this is around player behavior logging.
Technical details
Lotta fancy log stuff
Media
Requirements
License
MIT
Breaking changes
Changelog