New Icons

[pirakaplant]

About the PR

This PR:

• Adds most of the icon resprites from Funky Station to Forky.
• Updates a bunch of the icons to be more in-line with discussed department restructuring see (Command power structure overhaul docs#94 and [SOP Workgroup] Logistics & Service Restructuring docs#96).
• Updates several other icons (both Funky and new Wizden icons) for various reasons (readability, consistency, etc.)
• Reorganises the way icons are organised under _Funkystation for consistency and ease of use.
• Removes deprecated icons from the Agent ID card's library.

Why / Balance

1. On-palette and consistent icons are pretty neat.
2. The new designs look cool.
3. Quite a few icons are easier to read now, regardless of colour-sightedness.
4. This is a good first step in restructuring departments.

If the circumstances around where jobs are going change, this PR will be updated accordingly.

Technical details

All the new icons are filed under Resources/Textures/_Funkystation/Interface/Misc, in three different RSIs:

• job_icons.rsi: Any icon that can be used for an ID card (including Syndicate and Zombie, as the Agent ID has access to them) goes here.
• antag_icons.rsi: Any icon used to indicate antagonist factions (Blood Cult, Revolution, etc.) that isn't already under job_icons.rsi goes here.
• job_icons_borders.rsi: The mindshield and broken mindshield (the latter currently not implemented mechanically) sprites go here now, for consistency with Silicon crew indicators (which have a very similar form and function) in the main folders.

References to the original RSIs have been replaced with references to the new RSIs where appropriate (with deprecated icons pointing to the original to avoid "missing file" errors). These old icons have also had their allowSelection variables to false to prevent them from showing up in the Agent ID. The job.yml for wholly new icons is put under Resources/Prototypes/_Funkystation/StatusIcon. They have their own localisation strings under Resources/Locale/en-US/_Funkystation/job.

Media

(Red arrows indicate an "effective replacement", where the job icon does not replace the old icon entirely, but is slated for a job that will replace the job tied to the icon it replaces. The icon replacing the "?" is for the Hospitality Director outlined in funky-station/docs#96. )

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an in-game showcase.
• If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

Breaking changes

(Not sure how breaking these are. I'll remove them if they don't actually matter.)

• The Funky icon for the Quartermaster is called Quartermaster.png, and should be changed to that from QuarterMaster.png when referencing the icon in the new RSI.
• The Funky icon for the Salvage Specialist is called SalvageSpecialist.png, and should be changed to that from ShaftMiner.png when referencing the icon in the new RSI.

Changelog

🆑

• tweak: Changed most job and faction icons in the game, mostly ported over from Funky with some changes.
• add: Added icons for 14 new jobs.

[github-actions]

RSI Diff Bot; head commit 385a7bc merging into dee4856
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Funkystation/Interface/Misc/antag_icons.rsi

State	Old	New	Status
Changeling			Added
Cultist			Added
HeadRevolutionary			Added
InitialInfected			Added
MindControlled			Added
ParadoxClone			Added
Revolutionary			Added

Resources/Textures/_Funkystation/Interface/Misc/job_icons.rsi

State	Old	New	Status
Admin			Added
Assistant			Added
AtmosphericTechnician			Added
Bartender			Added
Borg			Added
Botanist			Added
Brigmedic			Added
CBURN			Added
Captain			Added
CargoTechnician			Added
CentralCommandIntern			Added
CentralCommandOfficial			Added
Chaplain			Added
Chef			Added
Chemist			Added
ChiefEngineer			Added
ChiefMedicalOfficer			Added
Clown			Added
Cluwne			Added
CommandMaid			Added
CorporateLiaison			Added
Cowboy			Added
DeathSquad			Added
Deputy			Added
Detective			Added
ERTChaplain			Added
ERTEngineer			Added
ERTJanitor			Added
ERTLeader			Added
ERTMedical			Added
ERTSecurity			Added
ExecutiveOfficer			Added
FitnessInstructor			Added
Geneticist			Added
HeadOfSecurity			Added
HospitalityDirector			Added
InternalAffairsAgent			Added
Janitor			Added
Lawyer			Added
Librarian			Added
Magistrate			Added
MedicalDoctor			Added
MedicalIntern			Added
Mime			Added
Musician			Added
NanotrasenCareerTrainer			Added
Ninja			Added
NoId			Added
Paramedic			Added
PartyMaker			Added
Pirate			Added
Prisoner			Added
Psychologist			Added
Quartermaster			Added
Reporter			Added
ResearchAssistant			Added
ResearchDirector			Added
Roboticist			Added
SalvageSpecialist			Added
Scientist			Added
SecurityCadet			Added
SecurityClown			Added
SecurityOfficer			Added
SeniorEngineer			Added
SeniorOfficer			Added
SeniorPhysician			Added
SeniorResearcher			Added
ServiceWorker			Added
StationAi			Added
StationEngineer			Added
Syndicate			Added
SyndicateCommander			Added
SyndicateCorpsman			Added
SyndicateOperative			Added
TechnicalAssistant			Added
Unknown			Added
Virologist			Added
Visitor			Added
Wizard			Added
Zombie			Added
Zookeeper			Added

Resources/Textures/_Funkystation/Interface/Misc/job_icons_borders.rsi

State	Old	New	Status
MindShieldBorder			Added
MindShieldBrokenBorder			Added

Edit: diff updated after 385a7bc

[TheHolyAegis]

One thing, weren't the dotted outline meant to show who knows the command manual?

[pirakaplant]

@TheHolyAegis

One thing, weren't the dotted outline meant to show who knows the command manual?

The dotted outline never really had any consistency in terms of its original usage. The Station AI got a dotted outline. Senior icons originally had a dotted outline before we changed them over to the new palette. It's been vaguely used to indicate "authority", "mindshield status", "expected to mentor", etc. with basically zero consistency. The "command training manual" interpretation is one I've never even heard of before.

Given that pretty much every interpretation of the dotted borders is subjective and often entirely superfluous, I opted to remove it after discussing the matter with @Teasq and @Catazeus. Also I think the icons look a lot better without them.