Conversation
There was a problem hiding this comment.
Pull request overview
This PR syncs the admin app with the latest OpenAPI schema changes from dotto-typespec, updating both the OpenAPI spec and the corresponding UI/data-fetching code paths in the timetable feature.
Changes:
- Removed day-of-week filtering from timetable list retrieval (API query param removed; UI and actions updated accordingly).
- Added support for associating rooms with a timetable item on creation (roomIds required in request; UI updated to allow multi-select).
- Updated timetable “new item” page to fetch and pass rooms to the form.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/timetable/TimetableItemForm.tsx | Adds multi-select room checkboxes and submits roomIds with the request. |
| src/components/timetable/TimetableFilterBar.tsx | Removes day-of-week filter UI and simplifies to semester + search. |
| src/app/dotto/timetable/page.tsx | Updates initial fetch call to match new fetchTimetableItems signature. |
| src/app/dotto/timetable/new/page.tsx | Fetches rooms alongside subjects and passes them to the client page. |
| src/app/dotto/timetable/new/NewTimetableItemPageClient.tsx | Threads rooms through to TimetableItemForm. |
| src/app/dotto/timetable/actions.ts | Removes dayOfWeek query usage from fetchTimetableItems. |
| src/app/dotto/timetable/TimetablePageClient.tsx | Removes selected-days state and updates search to call the new fetch signature. |
| openapi/openapi.yaml | Removes dayOfWeek query param and adds required roomIds to TimetableItemRequest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kantacky
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@a0afda6