Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repo’s OpenAPI spec and regenerated server bindings to introduce Firebase App Check as a first-class security scheme, and wires middleware enforcement through generated per-operation security markers.
Changes:
- Add
FirebaseAppCheckAuthsecurity scheme and make it the default global security requirement inopenapi.yaml. - Regenerate
generated/api.gen.goto set per-operation security scope markers for App Check and (where needed) Bearer auth. - Switch server bootstrapping to
RegisterHandlersWithOptionsto attach AppCheck/Auth middleware via generated handler options; add middleware unit tests.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openapi/openapi.yaml | Adds Firebase App Check security scheme + updates operation/global security requirements. |
| internal/middleware/auth.go | Makes Bearer auth enforcement conditional on generated scope markers. |
| internal/middleware/auth_test.go | Adds tests for conditional Bearer auth and context extractors. |
| internal/middleware/appcheck.go | Makes App Check enforcement conditional on generated scope markers. |
| internal/middleware/appcheck_test.go | Adds tests for conditional App Check header enforcement. |
| generated/api.gen.go | Adds FirebaseAppCheckAuthScopes and sets required security markers per operation. |
| cmd/server/main.go | Registers generated handlers with middleware options instead of global router.Use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@7c46061