Skip to content

Update OpenAPI schema#53

Merged
kantacky merged 5 commits intomainfrom
update-openapi-schema
Mar 29, 2026
Merged

Update OpenAPI schema#53
kantacky merged 5 commits intomainfrom
update-openapi-schema

Conversation

@dotto-api-schema-updater
Copy link
Copy Markdown
Contributor

This PR updates the OpenAPI schema from dotto-typespec.

Triggered by: fun-dotto/dotto-typespec@7c46061

@kantacky kantacky marked this pull request as ready for review March 29, 2026 11:53
@kantacky kantacky enabled auto-merge (squash) March 29, 2026 11:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repo’s OpenAPI spec and regenerated server bindings to introduce Firebase App Check as a first-class security scheme, and wires middleware enforcement through generated per-operation security markers.

Changes:

  • Add FirebaseAppCheckAuth security scheme and make it the default global security requirement in openapi.yaml.
  • Regenerate generated/api.gen.go to set per-operation security scope markers for App Check and (where needed) Bearer auth.
  • Switch server bootstrapping to RegisterHandlersWithOptions to attach AppCheck/Auth middleware via generated handler options; add middleware unit tests.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
openapi/openapi.yaml Adds Firebase App Check security scheme + updates operation/global security requirements.
internal/middleware/auth.go Makes Bearer auth enforcement conditional on generated scope markers.
internal/middleware/auth_test.go Adds tests for conditional Bearer auth and context extractors.
internal/middleware/appcheck.go Makes App Check enforcement conditional on generated scope markers.
internal/middleware/appcheck_test.go Adds tests for conditional App Check header enforcement.
generated/api.gen.go Adds FirebaseAppCheckAuthScopes and sets required security markers per operation.
cmd/server/main.go Registers generated handlers with middleware options instead of global router.Use.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openapi/openapi.yaml
Copy link
Copy Markdown
Member

@masaya-osuga masaya-osuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kantacky kantacky merged commit 9580e89 into main Mar 29, 2026
9 checks passed
@kantacky kantacky deleted the update-openapi-schema branch March 29, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants