Merged
Conversation
kantacky
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
FilterIsActive の判定条件に「公開開始日時（available_from）が現在時刻以前」を追加し、公開開始前の announcement が active 扱いで取得されてしまう挙動を修正するPRです。
Changes:
FilterIsActive有効時の絞り込み条件にavailable_from <= NOW()を追加- active 条件を「公開開始済み」かつ「公開終了前または終了日時未設定」に調整
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
FilterIsActiveの条件にavailable_from <= NOW()を追加確認したこと
メモ