Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the repository’s OpenAPI specifications and generated clients/handlers with the latest dotto-typespec updates, expanding the Admin BFF surface area for irregularity notifications, reservations, and user/FCM-token management.
Changes:
- Updated OpenAPI specs to add endpoints/schemas for cancelled classes, makeup classes, room changes, irregularity notifications, reservations, and user/FCM token APIs (plus search params like
q/floors). - Updated/added Gin handlers to proxy the newly introduced endpoints to upstream
academic_api/user_apiservices. - Regenerated the external
user_apiGo client to match the new schema (FCM tokens + users list).
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openapi/openapi.yaml | Main Admin BFF OpenAPI updated with new paths/tags/schemas and parameter changes. |
| openapi/external/user_api/openapi.yaml | External user service OpenAPI updated (FCM tokens + users list). |
| openapi/external/academic_api/openapi.yaml | External academic service OpenAPI updated (irregularities, reservations, room/cancel/makeup changes, search params). |
| internal/handler/user.go | Added Users list + upsert handlers using the user service client. |
| internal/handler/fcm_token.go | Added FCM token list + upsert handlers proxying to user service. |
| internal/handler/faculty.go | Updated faculties list handler to accept q query parameter. |
| internal/handler/room.go | Updated rooms list handler to use q + floors; removed old room-scoped reservations handler. |
| internal/handler/reservation.go | Added reservations list/create/detail/delete handlers for new /v1/reservations routes. |
| internal/handler/cancelled_class.go | Added cancelled classes list/create/fetch/delete handlers. |
| internal/handler/makeup_class.go | Added makeup classes list/create/fetch/delete handlers. |
| internal/handler/room_change.go | Added room changes list/create/fetch/delete handlers. |
| internal/handler/notify_irregularity.go | Added irregularity notification handler. |
| internal/handler/subject.go | Removed Subjects upsert handler to match schema removal. |
| generated/external/user_api/client.gen.go | Regenerated user_api client with FCM token models/endpoints and users list support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| parameters: | ||
| - name: id | ||
| in: path | ||
| required: true |
There was a problem hiding this comment.
POST /v1/users/{id} の path parameter id に description が無く、同じパスの GET では description: ユーザーID が定義されています。OpenAPI 上の一貫性/可読性のため、POST 側にも同様の description を追加してください。
Suggested change
| required: true | |
| required: true | |
| description: ユーザーID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@f631c30