Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes backend tooling/configuration by introducing the way submodule and replacing local root-level config files and CI/test workflows with references to shared assets in fun-dotto/way.
Changes:
- Adds the
waygit submodule and points repo-level configs (Dockerfile, Taskfile, mise, agent settings) to the submodule’s canonical versions. - Replaces the in-repo CI workflow with reusable workflows from
fun-dotto/way. - Refactors the CD workflow to use shared
set-envaction and updates checkout/auth/deploy steps.
Reviewed changes
Copilot reviewed 18 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| way | Adds way as a submodule commit pointer. |
| .gitmodules | Registers the way submodule and its remote URL. |
| mise.toml | Replaces local mise tool declarations with a pointer to the submodule version. |
| Taskfile.yml | Replaces local task definitions with a pointer to the submodule version. |
| Taskfile.yaml | Removes the previous Taskfile definitions (superseded by Taskfile.yml pointer). |
| Dockerfile | Replaces local Dockerfile content with a pointer to the submodule version. |
| .dockerignore | Replaces local ignore rules with a pointer to the submodule version. |
| CLAUDE.md | Replaces local Claude guidance with a pointer to the submodule version. |
| .mcp.json | Replaces local MCP server settings with a pointer to the submodule version. |
| .github/workflows/ci.yaml | Removes the in-repo CI workflow (superseded by reusable workflows). |
| .github/workflows/test.yml | Adds a reusable workflow-based test pipeline. |
| .github/workflows/update-submodules.yml | Adds a scheduled reusable workflow to update submodules. |
| .github/workflows/cd.yaml | Updates deploy workflow to use shared env setup + submodule checkout + newer Google actions. |
| .codex/skills | Points Codex skills to the submodule location. |
| .codex/config.toml | Points Codex config to the submodule location. |
| .codex/AGENTS.md | Points Codex agents doc to the submodule location. |
| .claude/skills | Points Claude skills to the submodule location. |
| .claude/settings.json | Points Claude settings to the submodule location. |
Comments suppressed due to low confidence (1)
Dockerfile:1
- This file appears to be intended as a symlink to a Dockerfile in the
waysubmodule. If it was committed as a regular text file (instead of a git symlink with mode 120000),docker build -f Dockerfilewill fail because Docker will try to parse./way/packaging/backend/Dockerfileas Dockerfile instructions. Please ensure this is committed as a symlink (and note that Windows checkouts may requirecore.symlinks=true).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,3 @@ | |||
| [submodule "way"] | |||
| path = way | |||
| url = git@github.com:fun-dotto/way.git | |||
There was a problem hiding this comment.
Using an SSH URL for the submodule (git@github.com:...) will fail in GitHub Actions (and for many contributors) unless SSH keys are explicitly configured. Prefer an HTTPS URL (e.g., https://github.com/fun-dotto/way.git) or add explicit SSH key setup in workflows that checkout submodules.
| url = git@github.com:fun-dotto/way.git | |
| url = https://github.com/fun-dotto/way.git |
| workflow_dispatch: | ||
| jobs: | ||
| update-submodules: | ||
| uses: fun-dotto/way/.github/workflows/update-submodules.yml@main |
There was a problem hiding this comment.
Reusable workflow is referenced by a floating ref (@main). For supply-chain safety and reproducibility, pin this to an immutable ref (a tag or commit SHA). This reduces the risk of unexpected behavior changes impacting scheduled runs.
| uses: fun-dotto/way/.github/workflows/update-submodules.yml@main | |
| uses: fun-dotto/way/.github/workflows/update-submodules.yml@f3a1b2c3d4e5f6g7h8i9j0k1l2m3n4o5p6q7r8 |
| workflow_dispatch: | ||
| jobs: | ||
| test: | ||
| uses: fun-dotto/way/.github/workflows/backend-test.yml@main |
There was a problem hiding this comment.
This workflow calls a reusable workflow pinned to @main. Pin to a tag or commit SHA to avoid unexpected changes in CI behavior (and to make builds reproducible).
| uses: fun-dotto/way/.github/workflows/backend-test.yml@main | |
| uses: fun-dotto/way/.github/workflows/backend-test.yml@v1 |
| - synchronize | ||
| workflow_dispatch: | ||
| jobs: | ||
| test: |
There was a problem hiding this comment.
The previous in-repo CI job explicitly skipped draft PRs (if: github.event.pull_request.draft == false). This caller workflow no longer has that guard, so tests will run on draft PR events (e.g., opened). If the prior behavior is still desired, add the draft condition at the job level in this workflow.
| test: | |
| test: | |
| if: github.event_name != 'pull_request' || github.event.pull_request.draft == false |
No description provided.