fix: Subject Listフィルタの子テーブル条件を単一サブクエリに統合#26
Merged
masaya-osuga merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
SubjectのListフィルタで、同一子テーブル(SubjectEligibleAttribute, SubjectRequirement)への条件が別々のサブクエリに分かれていたため、 両方指定時にAND条件として正しく機能しなかったバグを修正。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect AND behavior in SubjectRepository.List when multiple filters target the same child table, by consolidating those conditions into a single subquery per table.
Changes:
- Combine
Grade+Classfilters into oneSubjectEligibleAttributesubquery so both apply to the same row. - Combine
Courses+RequirementTypefilters into oneSubjectRequirementsubquery so both apply to the same row.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubjectEligibleAttribute（Grade, Class）とSubjectRequirement（Courses, RequirementType）のフィルタが、同一テーブルに対して別々のサブクエリを発行していたバグを修正Test plan
🤖 Generated with Claude Code