Merged
Conversation
hikaru-0602
requested review from
a team,
Copilot,
hikaru-0602,
kantacky and
masaya-osuga
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repo’s OpenAPI contract (sourced from dotto-typespec) and regenerates the Go API types accordingly, ensuring the server/client code stays in sync with the upstream schema change.
Changes:
- Add
roomIdsas a required field onTimetableItemRequestin the OpenAPI schema. - Regenerate Go API models to include
RoomIdsonTimetableItemRequest.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openapi/openapi.yaml | Makes roomIds a required request property for timetable item creation. |
| generated/api.gen.go | Updates generated request model to include RoomIds []string with json:"roomIds". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kantacky
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenAPI schema from dotto-typespec.
Triggered by: fun-dotto/dotto-typespec@a0afda6