Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
GET SubjectsV1_list のフィルタリングで必要となる classification / cultural_subject_category を subjects テーブル側に持たせ、DB保存・取得と検索条件に反映するPRです。
Changes:
subjectsの検索条件にclassification/cultural_subject_categoryを追加subjectsのUpsert時に上記カラムを更新対象に追加- domain/databaseモデルに2カラムを追加し、相互変換に反映
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/repository/subject.go | ListのWHERE句に2フィルタを追加、Upsertの更新対象カラムに2項目を追加 |
| internal/domain/subject.go | Subjectドメインモデルに Classification / CulturalSubjectCategory を追加 |
| internal/database/subject.go | GORMモデルに2カラムを追加し、DB↔domain変換に反映 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET SubjectsV1_listによるフィルタリングの際に必要だったフィールドをカラムに追加しました。