Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global using issue fixed #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ittyabrehman
Copy link

The globalUsings can not be auto-shared in cross-projects. so I added GlobalUsings.cs to compile for "Client" project automatically. Picks the file from "Client.Infrastructure" and adds it to "Client" at compile time.

@ittyabrehman ittyabrehman mentioned this pull request Apr 9, 2022
@ittyabrehman ittyabrehman reopened this Apr 9, 2022
@fretje
Copy link
Contributor

fretje commented Apr 10, 2022

Please don't do that.
globalusings.cs is not supposed to be shared between projects like that.

If you want a globalusings in the client project, create a specific one there...

@ittyabrehman
Copy link
Author

@fretje Thanks for your suggestion. Will change and creates a new PR

@fretje
Copy link
Contributor

fretje commented Apr 13, 2022

just pushing changes to the same branch will update the pr...

On a side note... I see you're pushing to your main branch... always create a new branch on your repo before starting work on a pr ;-)
Because now you might have merge issues when trying to pull from upstream...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants