Fix missing return type

Driver/ODM/Pager.php

@@ -17,6 +17,11 @@ class Pager implements PagerInterface, \IteratorAggregate, \Countable, \ArrayAcc
      */
     protected $lastPage;
 
+    /**
+     * @var integer
+     */
+    protected $page;
+
     /**
      * @var integer
      */
@@ -51,55 +56,55 @@ public function paginate($target, $page = 1, $limit = 10)
     /**
      * {@inheritdoc}
      */
-    public function getLastPage()
+    public function getLastPage(): int
     {
         return $this->lastPage;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getPage()
+    public function getPage(): int
     {
         return $this->page;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function haveToPaginate()
+    public function haveToPaginate(): bool
     {
         return $this->getLastPage() > 1;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getNbResults()
+    public function getNbResults(): int
     {
         return $this->nbResults;
     }
 
     /**
      * @param array $items items
      */
-    public function setItems(array $items)
+    public function setItems(array $items): void
     {
         $this->items = $items;
     }
 
     /**
      * @return \ArrayIterator
      */
-    public function getIterator()
+    public function getIterator(): \Traversable
     {
         return new \ArrayIterator($this->items);
     }
 
     /**
      * @return integer
      */
-    public function count()
+    public function count(): int
     {
         return count($this->items);
     }
@@ -108,7 +113,7 @@ public function count()
      * @param mixed $offset
      * @param mixed $value
      */
-    public function offsetSet($offset, $value)
+    public function offsetSet(mixed $offset, mixed $value): void
     {
         if (is_null($offset)) {
             $this->items[] = $value;
@@ -121,15 +126,15 @@ public function offsetSet($offset, $value)
      * @param  mixed   $offset
      * @return boolean
      */
-    public function offsetExists($offset)
+    public function offsetExists(mixed $offset): bool
     {
         return isset($this->items[$offset]);
     }
 
     /**
      * @param mixed $offset
      */
-    public function offsetUnset($offset)
+    public function offsetUnset(mixed $offset): void
     {
         unset($this->items[$offset]);
     }
@@ -138,8 +143,8 @@ public function offsetUnset($offset)
      * @param  mixed $offset
      * @return mixed
      */
-    public function offsetGet($offset)
+    public function offsetGet(mixed $offset): mixed
     {
-        return isset($this->items[$offset]) ? $this->items[$offset] : null;
+        return $this->items[$offset] ?? null;
     }
 }

Driver/ORM/Pager.php

@@ -58,39 +58,39 @@ public function paginate($target, $page = 1, $limit = 10)
     /**
      * {@inheritdoc}
      */
-    public function getLastPage()
+    public function getLastPage(): int
     {
         return $this->lastPage;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getPage()
+    public function getPage(): int
     {
         return $this->page;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function haveToPaginate()
+    public function haveToPaginate(): bool
     {
         return $this->getLastPage() > 1;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getNbResults()
+    public function getNbResults(): int
     {
         return $this->nbResults;
     }
 
     /**
      * @param array $items items
      */
-    public function setItems(array $items)
+    public function setItems(array $items): void
     {
         $this->items = $items;
     }

Driver/ORM/QueryBuilder/Criteria/CriteriaCollection.php

@@ -38,7 +38,7 @@ public function addFromAsserter(Asserter $asserter)
     /**
      * @return \ArrayIterator
      */
-    public function getIterator()
+    public function getIterator(): \Traversable
     {
         return new \ArrayIterator($this->criterias);
     }

Driver/ORM/QueryBuilder/QueryBuilder.php

@@ -131,6 +131,13 @@ protected function filterCriterias($qb)
             $visitor = new OperatorVisitor();
         } elseif ($this->criterias instanceof Asserter) {
             $visitor = new AsserterVisitor();
+        } else {
+            throw new \InvalidArgumentException(sprintf(
+                'Criterias must be an instance of %s or %s, %s given',
+                Operator::class,
+                Asserter::class,
+                get_class($this->criterias)
+            ));
         }
 
         $criteriaCollection = new CriteriaCollection();

Filter/DataHydrator/Locator/DoctrineORM.php

@@ -60,7 +60,7 @@ public function locate($model, array $components)
         }
 
         if (count($fields) > 1) {
-            return $this->locateComposite($objectManager, $metadata, $model, $components, $oids, $fields);
+            $this->locateComposite($objectManager, $metadata, $model, $components, $oids, $fields);
         }
 
         $alias = 'r';