Moved TODOs into github issues

fsprojects · Jan 14, 2025 · de43f2a · de43f2a
1 parent ac10cdd
commit de43f2a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 54 deletions.
diff --git a/TestDynamo/Client/Item.fs b/TestDynamo/Client/Item.fs
@@ -39,6 +39,14 @@ let buildUpdateConditionExpression
     ?|> Map.map either2Snd
     |> Fetch.buildFetchExpression "Expected" "ConditionExpression" "ue" op expression
 
+let private sizeEstimateRangeGB =
+    [| fstT Settings.TransactWriteSettings.SizeRangeEstimateResponse
+       sndT Settings.TransactWriteSettings.SizeRangeEstimateResponse |] |> ValueSome
+
+let private itemCollectionMetrics v =
+    { ItemCollectionKey = ValueSome v
+      SizeEstimateRangeGB = sizeEstimateRangeGB }: ItemCollectionMetrics<AttributeValue>
+
 module Put =
 
     let input (req: PutItemRequest<_>): PutItemArgs<Map<string,_>> =
@@ -57,7 +65,6 @@ module Put =
                 expressionAttrNames = req.ExpressionAttributeNames ?|? Map.empty |> addNames
                 expressionAttrValues = req.ExpressionAttributeValues ?|? Map.empty |> addValues } } : PutItemArgs<_>
 
-        // 'a -> Map<string,AttributeValue> voption -> PutItemResponse
     let output databaseId (attributes: Map<string,_> voption): PutItemResponse<_> =
 
         { Attributes = attributes
@@ -385,14 +392,6 @@ module Transact =
               idempotencyKey = req.ClientRequestToken |> noneifyStrings 
               conditionCheck = condition |> Maybe.traverse |> List.ofSeq } : Database.TransactWrite.TransactWrites
 
-        let private sizeEstimateRangeGB =
-            [| fstT Settings.TransactWriteSettings.SizeRangeEstimateResponse
-               sndT Settings.TransactWriteSettings.SizeRangeEstimateResponse |] |> ValueSome
-
-        let private itemCollectionMetrics v =
-            { ItemCollectionKey = ValueSome v
-              SizeEstimateRangeGB = sizeEstimateRangeGB }: ItemCollectionMetrics<AttributeValue>
-
         let output _ (modifiedTables: Map<string, Map<string, AttributeValue> list>): TransactWriteItemsResponse<AttributeValue> =
 
             let metrics = 

diff --git a/TestDynamo/Model/Compiler.PrecedenceProcessor.fs b/TestDynamo/Model/Compiler.PrecedenceProcessor.fs
@@ -207,14 +207,13 @@ module PrecedenceProcessor =
         | head::_ when head.fromToken = from && head.toToken = ``to`` -> ValueSome head
         | _::tail -> isProcessed' from ``to`` tail
 
-    // O(N) operation on an ever shinking number of nodes
-    // probaly does not need to be optimised for small collections
-    let alreadyProcessed from ``to`` =
-        function
-        | Pp { processed = processed } -> isProcessed' from ``to`` processed
+    // O(N) operation on an ever shrinking number of nodes
+    // probably does not need to be optimised for small collections
+    let alreadyProcessed from ``to`` (Pp { processed = processed }) =
+        isProcessed' from ``to`` processed
 
     /// <summary>
-    /// Put a tokenization reuslt into the processor, replacing
+    /// Put a tokenization result into the processor, replacing
     /// any tokens or other results which were in its place
     /// </summary>
     let put =

diff --git a/TestDynamo/TODO.txt b/TestDynamo/TODO.txt
diff --git a/tests/TestDynamo.Tests/MappingTests.fs b/tests/TestDynamo.Tests/MappingTests.fs
@@ -416,7 +416,6 @@ type MappingTests(output: ITestOutputHelper) =
             TestDynamo.GeneratedCode.Dtos.QueryRequest<AttributeValue>> data
 
         // assert
-        // Assert.NotNull(data.Statements) - todo Dynamodb v3 only
         Assert.Equal(ValueNone, result.AttributesToGet)
 
     [<Fact>]