Skip to content

Conversation

@xperiandri
Copy link

No description provided.

@isaacabraham
Copy link
Collaborator

@xperiandri firstly thank you for creating this PR and apologies (I know we've spoken already about this) for the delay in getting to it.

At first glance, is there a reason why we need to move to three separate type providers? What are the benefits from both the user's point of view as well as development experience?

@isaacabraham
Copy link
Collaborator

@xperiandri I've picked up where I left off with the TP - basically the latest versions of F# have build issues relating to the use of the FSharp Compiler Tools dependency (which is coupled to F#4.1) so I'm removing that dependency, whilst also upgrading to FAKE 5. Once they're both out of the way (hopefully today) let's work together to get this ready to go in - I'm willing to split out into three assemblies as long as it's clear what the benefits are.

@xperiandri
Copy link
Author

Sounds good
Was I wrong changing getting current executing assembly to getting current assembly?

@isaacabraham
Copy link
Collaborator

@xperiandri where? I'm just getting the current couple of branches merged into master and then will start looking at this PR in more detial.

# Conflicts:
#	.paket/Paket.Restore.targets
#	build.fsx
#	paket.dependencies
#	paket.lock
@xperiandri
Copy link
Author

OK
In TP initialization

@xperiandri
Copy link
Author

By the way, I would prefer to move to a model where you can create a provider with a connection string.
Like ExcelProvider does.

@isaacabraham
Copy link
Collaborator

@xperiandri you can already do that?

@xperiandri
Copy link
Author

I mean dynamically. Now you either pass it into TP in code, or when calling a method

@isaacabraham
Copy link
Collaborator

isaacabraham commented Jun 18, 2019

So move away from method-based overrides to a single override at the "top" level? That's something I'd love to do. (btw you can specify a config file as well).

@xperiandri
Copy link
Author

Yes. Cool!

@isaacabraham
Copy link
Collaborator

Regarding get executing assembly vs current assembly using a type - both should work; is there any difference?

@xperiandri
Copy link
Author

I guessed that it will fix an issue with that you need to have Tables.json in all project referencing project with type provider

@xperiandri
Copy link
Author

I've rebased my changed on top of yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants