Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postulate that snippet tags be closed #95

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Postulate that snippet tags be closed #95

merged 4 commits into from
Oct 17, 2024

Conversation

carmenbianca
Copy link
Member

@carmenbianca
Postulate that snippet tags be closed
8327670 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
@carmenbianca
Add change log entry
18eeac1 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
carmenbianca commented Sep 27, 2024
View reviewed changes
site/content/en/spec-3.3.md Outdated
Comment on lines 180 to 181
whole Commentable File. For these cases SPDX snippet tags MUST be used for that
whole Commentable File. For these cases, SPDX snippet tags MUST be used for that
Snippet (as defined in [SPDX Specification, Annex
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, even when corrected, this language is awkward. Let's reword.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disambiguate: make SPDX snippets optional

@carmenbianca
Reword ambiguous snippet text
1fb2249 
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
silverhook
silverhook approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@silverhook silverhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe dobule-check if “Snippets” vs “snippets” (case) is coherently used in the section.

@carmenbianca
Copy link
Member Author

Fixed, thank you!

@carmenbianca carmenbianca merged commit 12d01af into fsfe:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverhook silverhook silverhook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmenbianca @silverhook