Updated contract deposit_erc20 #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsainas
requested changes
May 11, 2025
Owner
fsainas
left a comment
fsainas
left a comment
There was a problem hiding this comment.
Hello,
It seems this use case doesn't fully follow the standard. The Makefile differs from the one in the template directory, and getters.sol and methods.sol are missing from the Certora directory. Lastly, it seems the Hardhat proof of concept is missing from the changes. Please refer to the README for the exhaustive use case specification and update the PR accordingly.
Thanks!
…r according to the actual standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to deposit_erc20 contract: