Update eslint #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s plugin config for non-compiler projects for now
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates ESLint from versions 7.x/8.x to 9.39.2, introduces a shared ESLint configuration package, migrates to ESLint's flat config format, and makes related improvements to TypeScript configurations and code quality across the monorepo.
Key changes:
- Upgrade ESLint to version 9.39.2 with flat config format
- Create shared
@repo/eslint-configand@repo/typescript-configpackages - Rename turbo task from
check-typestotype-checkfor consistency - Apply ESLint fixes and type improvements across the codebase
- Update React component patterns and accessibility attributes
Reviewed changes
Copilot reviewed 54 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml, pnpm-lock.yaml | Added ESLint to catalog, updated dependencies including turbo, rollup, and ESLint plugins |
| turbo.json | Renamed task from check-types to type-check, added globalEnv configuration |
| packages/eslint-config/* | New shared ESLint configuration package with base and React configs |
| packages/typescript-config/* | New shared TypeScript configuration package with base and Next.js configs |
| packages/vaul/* | Migrated to ESLint 9, improved type safety, added proper React imports, fixed accessibility issues |
| packages/test-app/* | Updated TypeScript config to extend shared config, fixed React prop attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…act version due to runtime changes (`react-jsx` instead of `react` for "jsx" in tsconfig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds typescript-config package