Migrate frontpage identity operations to use atcute #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
vercel
bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates identity operations from custom implementation to the atcute library, replacing homebrew handle/DID resolution code with @atcute/identity and @atcute/identity-resolver packages. This migration prepares the codebase for future did:web support by enabling the use of atcute's hybrid DID resolver.
Key Changes:
- Replaced custom DNS and HTTP handle resolution with atcute's
CompositeHandleResolver - Migrated DID document fetching from manual PLC directory calls to atcute's
PlcDidDocumentResolver - Centralized User-Agent string into a constant and updated its value
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added atcute packages to catalog with version constraints |
| pnpm-lock.yaml | Updated lockfile with atcute dependencies and transitive dependencies |
| packages/frontpage/package.json | Added @atcute/identity and @atcute/identity-resolver dependencies |
| packages/frontpage/lib/data/atproto/identity.ts | Replaced custom handle resolution with atcute's CompositeHandleResolver |
| packages/frontpage/lib/data/atproto/did.ts | Migrated DID document resolution to atcute's PlcDidDocumentResolver, narrowed DID type |
| packages/frontpage/lib/constants.ts | Added FRONTPAGE_APPVIEW_USER_AGENT constant |
| packages/frontpage/lib/auth.ts | Updated to use centralized User-Agent constant |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
vercel
bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
vercel
bot
temporarily deployed
to
Preview – frontpage-oauth-preview-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our homebrew handle/did resolution code, it shouldn't change the behaviour at all.
It makes it easier for us to support did:webs in a followup PR because we can just swap plc resolver for the hybrid did:plc/did:web one.
To unblock did:web support we need to figure out did:web deletion, see https://bsky.app/profile/did:plc:2xau7wbgdq4phuou2ypwuen7/post/3mab3ukanu226