Fix "Shutdown" not working & fix NPE in Pictures #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only check for jsonShares' being null and return if that is the case. Shares object might not be null but the sources node might be. Verify it's not null before continuing.
Shutdown uses the EventServer and this brings up the shutdown dialog where you need to choose what to do. This behaviour is not inline with what we experience on iOS client and makes it hard to shut down a system from remote as the selection might end up in dialog close or the first item. Convert the call to JSON-RPC instead. This will gracefully shutdown the XBMC server and power off the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown uses the EventServer and this brings up the shutdown
dialog where you need to choose what to do. This behaviour is not
inline with what we experience on iOS client and makes it hard to
shut down a system from remote as the selection might end up in
dialog close or the first item. Convert the call to JSON-RPC
instead. This will gracefully shutdown the XBMC server and power
off the system