Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(background): Adds end-of-year pop-up #408

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat(background): Adds end-of-year pop-up #408

merged 3 commits into from
Dec 3, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Dec 2, 2024 •
edited
Loading

This PR closes freelawproject/recap#384 by implementing functionality to open the donation page in a new tab.

@ERosendo ERosendo added the no changelog Override Check Changelog Action. label Dec 2, 2024
@ERosendo ERosendo removed the no changelog Override Check Changelog Action. label Dec 2, 2024
@ERosendo ERosendo requested a review from mlissner December 2, 2024 13:38
@ERosendo ERosendo marked this pull request as ready for review December 2, 2024 13:38
mlissner
mlissner approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Let's make sure that link exists before we launch this though!

@mlissner mlissner merged commit 2c52fd3 into main Dec 3, 2024
8 checks passed
@mlissner mlissner deleted the 384-feat-add-end-of-the-year-popup branch December 3, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlissner mlissner mlissner approved these changes

Assignees

@mlissner mlissner

Labels
None yet
Projects
Sprint (Web Team)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do RECAP end of year pop up
2 participants
@ERosendo @mlissner