fix(background): use chrome.scripting.ExecutionWorld.MAIN for firefox compatibility #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttys0dev
force-pushed
the
fix-firefox-world
branch
2 times, most recently
from
c4eef14 to
d197f9c
Compare
ttys0dev
force-pushed
the
fix-firefox-world
branch
from
d197f9c to
8dc807a
Compare
|
rebased |
|
@ERosendo Does this look good to merge? |
|
@ttys0dev, what's the impact of this being wrong? |
I was seeing an exception being thrown. |
|
What version of FF? |
Was some ESR version I think where I saw the error, may have updated it since I tested though(currently on version 128 looks like). |
|
Cool. We're not making much effort to support old FF versions, but if this works on both, we might as well merge. I leave it to Eduardo to make that decision. |
|
@ttys0dev I've tested this change in the latest versions of Chrome, Firefox, and Safari. While it works properly in Chrome and Firefox, it breaks the extension in Safari. I've verified that the code from the main branch works as expected in Safari. |
- Detect Safari browser explicitly - Adjust execution world to 'MAIN' for Safari, 'chrome.scripting.ExecutionWorld.MAIN' for other browsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems firefox is picky here and won't accept the a
MAINstring.