Skip to content

Commit

Permalink
fix(page identification): Better support for show_doc att pages
Browse files Browse the repository at this point in the history
Attachment pages can be identified by either doc1 or show_doc URLs. Currently, we
do not identify these pages correctly if they are behind a show_doc URL. This means
that we do not upload them. With the better abstraction introduced in the prior
commit, it's easy to do this correctly, ensuring that these get uploaded when they
should.
  • Loading branch information
mlissner committed Dec 16, 2017
1 parent b9a1683 commit c592381
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pacer.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ let PACER = {
// attachments for a particular document).
isAttachmentMenuPage: function (url, document) {
let inputs = document.getElementsByTagName('input');
let pageCheck = url.match(/\/doc1\/\d+/) &&
let pageCheck = PACER.isDocumentUrl(url) &&
inputs.length &&
inputs[inputs.length - 1].value === 'Download All';
return !!pageCheck;
Expand Down

0 comments on commit c592381

Please sign in to comment.