Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(judge-pics): remove support for python 3.8 and below #26

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

quevon24
Copy link
Member

  • Dropped support for Python 3.7 and 3.8
  • Fixed various Pylint warnings and errors:
    • Added encoding to open() calls
    • Replaced overly general exceptions with more specific ones
    • Removed unused imports
    • Fixed string formatting issues
    • Added missing timeout parameter in requests.get() to prevent potential infinite waits
    • Renamed parameter license to avoid conflict with built-in constant
  • Update upload, lint and test workflows
  • Add typing and documentation to the functions where it is missing
  • Add workflow to check for new entries in CHANGES.md file
  • Add CHANGES.md file

@quevon24 quevon24 linked an issue Feb 18, 2025 that may be closed by this pull request
@flooie
Copy link
Contributor

flooie commented Feb 21, 2025

Was this an issue?

@quevon24
Copy link
Member Author

Was this an issue?

Python 3.7 and 3.8 are no longer supported: https://devguide.python.org/versions/#unsupported-versions

@mlissner
Copy link
Member

I think tests weren't passing on a different repo, so Kevin began upgrading them as he added the change detector CI test.

@flooie flooie merged commit f56f9ac into main Feb 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove support for Python 3.7 and 3.8
3 participants