fix(hyperscan): Handles the InvalidError exception during db loading. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERosendo
force-pushed
the
fix-handle-invalid-error-while-loading-db
branch
from
a72a022 to
667fae5
Compare
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 0 losses. Click here to see details.
Time Chart
Generated Files |
mlissner
reviewed
May 22, 2024
|
Sounds good, thanks. Merging. We can cut a release if we want or just let it be. This is rare enough, I think we can wait, and I think we have another issue about not recognizing citations that we'll need to pull in soon anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic to handle the
InvalidErrorexception during loading the cached hyperscan db and fixes #4053.According to the documentation, this error (
InvalidError) is only returned when the function detects an invalid parameter. Sinceloaddbonly takes one parameter(the serialized Hyperscan database), this error indicates a problem with the input ByteString. The current fix addresses this by triggering a full database recompile whenever this exception is encountered.