Skip to content

fix(security): replace hardcoded S3 credentials with environment variables #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aaloklovanshi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(security): replace hardcoded S3 credentials with environment variables #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
056b4ff
fix(security): replace hardcoded S3 credentials with environment vari…
freeediting35-png May 16, 2026
33fbb59
fix(security): sanitize all environment credentials
freeediting35-png May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/config/main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
'temporaryBucketResourceManager' => [
'class' => 'common\components\S3ResourceManager',
'region' => 'eu-west-2', // Bucket based in London
'key' => 'AKIAWMITDJRKVN5ODY2X',
'secret' => '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',
'key' => getenv('AWS_TEMP_BUCKET_KEY'),
'secret' => getenv('AWS_TEMP_BUCKET_SECRET'),
'bucket' => 'studenthub-public-anyone-can-upload-24hr-expiry'
/**
* You can access the Temporary bucket with:
Expand Down
13 changes: 0 additions & 13 deletions common/fixtures/CandidateVideoLogFixture.php
View file
Open in desktop

This file was deleted.

Loading