Ensure /etc/iptables exists before writing to it #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This is submitted untested) |
In the specific case of installing a fresh mon server when the app server is already configured AND you're using ssh over the local network, we'll try to write to /etc/iptables before the iptables-persistent package is installed. This is because we end up running the restrict-direct-access role before the common role, which installs the base packages. The easy fix is to install iptables-persistent ahead of time if we see that it's necessary. Fixes #7119.
legoktm
force-pushed
the
stg-iptables-mon
branch
from
96a0f03 to
8efcabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
In the specific case of installing a fresh mon server when the app server is already configured AND you're using ssh over the local network, we'll try to write to /etc/iptables before the iptables-persistent package is installed.
This is because we end up running the restrict-direct-access role before the common role, which installs the base packages.
The easy fix is to install iptables-persistent ahead of time if we see that it's necessary.
Fixes #7119.
Testing
How should the reviewer test this PR?
./securedrop-admin install(i.e. with the cherry-pick)Deployment
Any special considerations for deployment? n/a, bug only affects fresh installs
Checklist