Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support noble dev environment and pass tests #7249

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Oct 15, 2024

Status

Ready for review

Description of Changes

Refs #7210

Changes proposed in this pull request:

  • see individual commit messages for details.

Testing

How should the reviewer test this PR?

  • CI passes
  • UBUNTU_VERSION=noble make dev works locally

Deployment

Any special considerations for deployment? No, everything should be backwards-compatible with focal

Checklist

@legoktm legoktm added the noble Ubuntu Noble related work label Oct 15, 2024
@legoktm legoktm requested a review from a team as a code owner October 15, 2024 21:27
@legoktm
Copy link
Member Author

legoktm commented Oct 15, 2024

Still needs some work before being merge ready, but the changes themselves are ready for review.

A few notes on diff reviews...

* Stop pinning the exact SHA256 of the image, we actually want to be
  using the latest version to match what prod servers are doing. (And what
  we do in the builder now).
* noble images ship with a default `ubuntu` user (UID 1000), which
  conflicts with podman's ID mapping, so delete it if exists.
* Partition cargo build cache based on version so it doesn't link to the
  wrong C system libraries.
* Install libasound2-dev so it picks up the correct library package
  regardless of OS version.
Needed for Python 3.12 compatibility. Strictly speaking we only need to
go to 1.0.5, but let's go all the way to 1.1.0 for consistency with
SecureDrop Client.
For compatibility with Python 3.12. Upgrade across the board, including
in the admin workstation, for consistency.
Needed for Python 3.12 compatibility.
It emits a warning saying it has no effect, so just drop it entirely.
Since noble will use a fixed version of GPG, we can just check equality
of the version instead of implementing proper version comparison
schemes.
@legoktm
Copy link
Member Author

legoktm commented Oct 22, 2024

diff reviews are all done now.

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is great progress towards hopefully a chill April.

@zenmonkeykstop zenmonkeykstop added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 1971bbf Oct 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noble Ubuntu Noble related work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants