-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support noble dev environment and pass tests #7249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs some work before being merge ready, but the changes themselves are ready for review. A few notes on diff reviews...
|
* Stop pinning the exact SHA256 of the image, we actually want to be using the latest version to match what prod servers are doing. (And what we do in the builder now). * noble images ship with a default `ubuntu` user (UID 1000), which conflicts with podman's ID mapping, so delete it if exists. * Partition cargo build cache based on version so it doesn't link to the wrong C system libraries. * Install libasound2-dev so it picks up the correct library package regardless of OS version.
Needed for Python 3.12 compatibility. Strictly speaking we only need to go to 1.0.5, but let's go all the way to 1.1.0 for consistency with SecureDrop Client.
For compatibility with Python 3.12. Upgrade across the board, including in the admin workstation, for consistency.
Needed for Python 3.12 compatibility.
It emits a warning saying it has no effect, so just drop it entirely. Since noble will use a fixed version of GPG, we can just check equality of the version instead of implementing proper version comparison schemes.
diff reviews are all done now. |
zenmonkeykstop
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is great progress towards hopefully a chill April.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Refs #7210
Changes proposed in this pull request:
Testing
How should the reviewer test this PR?
UBUNTU_VERSION=noble make dev
works locallyDeployment
Any special considerations for deployment? No, everything should be backwards-compatible with focal
Checklist
make lint
) and tests (make test
) pass in the development container