Set 30 day retention period for apache logs

[starchy]

Status

Ready for review / Work in progress

Description of Changes

Fixes #304.

Changes proposed in this pull request:

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

Deployment

Any special considerations for deployment? Consider both:

1. Upgrading existing production instances.
2. New installs.

Checklist

If you made changes to the server application code:

• Linting (make ci-lint) and tests (make -C securedrop test) pass in the development container

If you made changes to securedrop-admin:

• Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

• Configuration tests pass

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

If you made changes to documentation:

• Doc linting (make docs-lint) passed locally

[zenmonkeykstop]

Hi @starchy - this PR will probably need a rebase before review and merge. Do you have cycles available for it, or would you be OK with somebody else picking it up?

[starchy]

I'm going on leave with limited internet access soon so it's probably best if someone else grabs it. Thanks for asking!

…

On Mon, Jun 10, 2019, 08:05 zenmonkeykstop ***@***.***> wrote: Hi @starchy <https://github.com/starchy> - this PR will probably need a rebase before review and merge. Do you have cycles available for it, or would you be OK with somebody else picking it up? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3714?email_source=notifications&email_token=AACI3CVIJPR2ZKQVUW5KZBDPZZUU7A5CNFSM4FP4W3LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXKEODQ#issuecomment-500451086>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACI3CQXUTD73ESMCZUZJHDPZZUU7ANCNFSM4FP4W3LA> .

[eloquence]

Hi @starchy, sorry for the long silence on this PR. We're still interested in landing this change. There are no concerns in principle about reducing the retention from the perspective of tech support for newsrooms, though we may want to give organizations a heads up that this is coming.

Because this requires a run of the Ansible playbook to be applied to all configurations, one option we're considering is to fold this change into the release which will add support for the next LTS release of Ubuntu, where a playbook run will be required. This would ensure that we avoid too much configuration drift between new installs and existing ones. So just a heads up that this PR may remain open quite a bit longer (the current LTS reaches end-of-life on April 30, 2021).

[cfm]

It looks like we missed this pull request as part of the Xenial-to-Focal migration. @zenmonkeykstop (CC: @eloquence), is this something you'd be interested in pulling into either v2.6.1 or v2.7.0? Re: configuration drift, we could tack on a postinst fixup.

[cfm]

Believe it or not...we'll pick this (back!) up for SecureDrop 2.12 towards compatibility with Ubuntu Noble. We'll take on the task of adding an upgrade (whether postinst-based or otherwise) path.