Skip to content

Commit

Permalink
Disable "protocol" check from html_lint.py
Browse files Browse the repository at this point in the history
This actively dissuades from using HTTPS URLs, favoring
protocol-relative ones. Even ignoring HTTPS-only URLs as a best
practice, given most onion services are hosted as HTTP sites,
they'd become HTTP links instead of HTTPS.

So let's just suppress this rule and link to the correct protocol.
  • Loading branch information
legoktm committed Nov 22, 2024
1 parent 0517e37 commit 037055d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ fix: ruff ## Apply automatic fixes.
.PHONY: html-lint
html-lint: ## Validate HTML in web application template files.
@echo "███ Linting application templates..."
@html_lint.py --printfilename --disable=optional_tag,extra_whitespace,indentation,names,quotation \
@html_lint.py --printfilename --disable=optional_tag,extra_whitespace,indentation,names,quotation,protocol \
securedrop/source_templates/*.html securedrop/journalist_templates/*.html
@echo

Expand Down

0 comments on commit 037055d

Please sign in to comment.