Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label accessibility #886

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Label accessibility #886

merged 2 commits into from
Aug 18, 2021

Conversation

chigby
Copy link
Contributor

@chigby chigby commented Aug 16, 2021

This PR fixes the first two tasks in #865:

  1. Adds a missing id attribute on the directory page for the Topic dropdown
  2. Adds a screen-reader only label for the search box on the Search page.

chigby added 2 commits August 16, 2021 15:22
@chigby
directory page: Associate label with Topic dropdown
3d7db92 
The label was there, but the lack of an `id` attribute was preventing
the association.
@chigby
search page: Add label for search box
d034c68
SaptakS
SaptakS approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaptakS SaptakS merged commit d132d9e into develop Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptakS SaptakS SaptakS approved these changes

@harrislapiroff harrislapiroff Awaiting requested review from harrislapiroff harrislapiroff is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chigby @SaptakS