Always set a VM's internalness #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have my normal SDW testing machine with me so I haven't been able to test this at all. |
legoktm
force-pushed
the
always-internal
branch
from
473526e to
cdf26ef
Compare
3 tasks
legoktm
commented
Dec 11, 2024
To ensure we correctly flip the status of a VM's internal feature or not, ensure the property is always being set, but conditional the value on the environment. And then explicitly set sd-app and sd-gpg as non-internal, so that salt will update them from when they used to be internal (see e754b40). Refs #1214
legoktm
force-pushed
the
always-internal
branch
from
cdf26ef to
8e3232e
Compare
deeplow
reviewed
Dec 12, 2024
deeplow
approved these changes
Dec 17, 2024
deeplow
added a commit
to deeplow/securedrop-workstation
that referenced
this pull request
Jan 16, 2025
With freedomofpress#1219 sd-app and sd-proxy were explicitly as "internal: 0". However, this does not work, as the developer docs warn [1]: > Some extensions interpret the values as boolean. In this case, > the empty string means False and non-empty string (commonly '1') > means True. To fix this, the internalness of a qube is explicitly set to "". [1]: https://dev.qubes-os.org/projects/core-admin-client/en/latest/manpages/qvm-features.html#description
4 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
To ensure we correctly flip the status of a VM's internal feature or not, ensure the property is always being set, but conditional the value on the environment.
And then explicitly set sd-app and sd-gpg as non-internal, so that salt will update them from when they used to be internal (see e754b40).
Refs #1214
Testing
Deployment
Any special considerations for deployment? This is to implement handling for upgrades.
Checklist
make test) pass indom0