Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Backport Set sd-whonix and sd-devices menu items #1121

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Jul 3, 2024

Status

Ready for review

Description of Changes

Backport #1112

Testing

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing pilot instances
  2. New installs

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0

If you have added or removed files

  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

If documentation is required

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation

These are the only two VMs that will be visible on production systems
and have specific tools we want users to be able to directly start.

* sd-devices: Files (Nautilus) and Disks
* sd-whonix: Anon Connection Wizard and Tor Control Panel

Ideally we would do all of this in salt, but since we need to run stuff
via dom0 after we do things in the VMs, it would require adjusting the
order of some salt states, which is a bit too intrusive for a fix during
the RC/QA period.

A TODO indicates that this is not an ideal situation, and
<freedomofpress/securedrop-client#2078> tracks
one potential fix.

Fixes #520.
Fixes #1109.
@rocodes rocodes requested a review from legoktm July 3, 2024 20:25
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, just waiting for CI

@legoktm legoktm mentioned this pull request Jul 3, 2024
1 task
@legoktm legoktm merged commit 8531ba6 into release/1.0.0 Jul 3, 2024
7 checks passed
@legoktm legoktm deleted the backport-menu-items branch July 3, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants