Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sdw-login.py and .desktop file with systemd user unit #1086

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Jun 17, 2024

Status

Ready for review [will flip out of draft mode after testing]

Description of Changes

Fixes #1073

Changes proposed in this pull request:

  • Add user systemd unit to autostart sdw-updater (updater/login)
  • remove sdw-login.py and autostart .desktop file

Testing

  • CI passing
  • Manual testing: login/updater appear on start of user session

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing pilot instances
  2. New installs

Checklist

If you have made changes to the provisioning logic

  • All tests (make test) pass in dom0

If you have added or removed files

  • I have updated MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

If documentation is required

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation

@rocodes rocodes force-pushed the 1073-sdw-login-systemd branch from db1a4ba to 7c8e768 Compare June 17, 2024 23:01
@rocodes rocodes added this to the 1.1.0 milestone Nov 26, 2024
@rocodes
Copy link
Contributor Author

rocodes commented Nov 26, 2024

Commenting based on discussion: we may want to revisit whether autostart is a feature we want to support in any case

@zenmonkeykstop zenmonkeykstop removed this from the 1.1.0 milestone Nov 26, 2024
@rocodes
Copy link
Contributor Author

rocodes commented Dec 6, 2024

(Once #1088 lands I will update this PR to use the same approach and add this unit to the presets file)

@rocodes rocodes force-pushed the 1073-sdw-login-systemd branch from 7c8e768 to 26d95af Compare December 6, 2024 21:49
@rocodes rocodes force-pushed the 1073-sdw-login-systemd branch from 26d95af to 07e33da Compare January 16, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

sdw-login should probably be started by a systemd unit instead of autostart entry
2 participants