Add minimal code review policy #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly describing existing practice more explicitly
eloquence
commented
Mar 4, 2025
eloquence
commented
Mar 4, 2025
|
|
||
| If multiple individuals collaborate on a single PR, it is acceptable for | ||
| cross-review by the authors to take place during development, but there must not be | ||
| any unreviewed changes in the pull request at the time of approval. |
There was a problem hiding this comment.
This is beyond the scope of what we discussed but I figured would be good to call out explicitly as I think it's existing practice, but happy to tweak.
There was a problem hiding this comment.
Agreed that this is existing practice.
legoktm
approved these changes
Mar 5, 2025
|
|
||
| If multiple individuals collaborate on a single PR, it is acceptable for | ||
| cross-review by the authors to take place during development, but there must not be | ||
| any unreviewed changes in the pull request at the time of approval. |
There was a problem hiding this comment.
Agreed that this is existing practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Mostly describing existing practice more explicitly, but specifically setting clear expectation for new repos added to the any production code.
Description of Changes
Checklist (Optional)
make docs-lint) passed locallymake docs-linkcheck) passedmake docs) docs at http://localhost:8000