Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /dev/xen/hypercall to AppArmor allow-list #1530

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add /dev/xen/hypercall to AppArmor allow-list #1530

merged 1 commit into from
Jun 28, 2022

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Jun 28, 2022

Access to this device-node is required on kernel versions 4.18 or greater (per commit message QubesOS/qubes-linux-utils@4fe08d3 and AppArmor denials when testing with the newer kernel that ships with the Bullseye template).

Description

Fixes the proxy error and disposable VM opening errors described in freedomofpress/securedrop-workstation#600 (comment)

Test Plan

On a system that exhibits the issue, apply this fix (either by modifying the AppArmor profile in /etc/apparmor.d, or building a new package from this branch and installing it), restart AppArmor and verify that the issue is resolved.

Checklist

  • I have tested these changes in the appropriate Qubes environment
  • I have updated the AppArmor profile
  • No database schema changes are needed

Access to this device-node is required on kernel versions 4.18 or greater.
@eloquence eloquence requested a review from a team as a code owner June 28, 2022 03:02
@eloquence eloquence changed the title Add /dev/xen/hypercall to allow-list Add /dev/xen/hypercall to AppArmor allow-list Jun 28, 2022
@eaon eaon added the qubes-4.1 label Jun 28, 2022
@eaon eaon self-assigned this Jun 28, 2022
Copy link
Contributor

@eaon eaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happily confirming that this works 😄

@eaon eaon merged commit bf9a196 into main Jun 28, 2022
@eaon eaon deleted the hypercall-denied branch June 28, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants