Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 4.14.150 kernel image package and metapackage #21

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Adds 4.14.150 kernel image package and metapackage #21

merged 1 commit into from
Nov 12, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Oct 28, 2019 •
edited
Loading

See freedomofpress/ansible-role-grsecurity-build#51 for config and build changes introduced.

@redshiftzero redshiftzero mentioned this pull request Oct 28, 2019
Merged
10 tasks
@emkll emkll mentioned this pull request Oct 30, 2019
Merged
6 tasks
@emkll emkll changed the title Adds 4.14.150 kernel image package and metapackage [WIP] Adds 4.14.150 kernel image package and metapackage Oct 30, 2019
@emkll
Copy link
Contributor Author

emkll commented Oct 30, 2019

@zenmonkeykstop has identified some issues on NUC7's, marking this PR as WIP until we identify and fix the issue

@emkll emkll force-pushed the sd-core-4.14.150-kernels branch from ee5895b to f46ba5d Compare November 5, 2019 23:17
@emkll
Copy link
Contributor Author

emkll commented Nov 5, 2019

Based on discussions with @rmol and @zenmonkeykstop , the issue has been isolated to EFI support. An updated 4.14 config has been submitted: freedomofpress/ansible-role-grsecurity-build#52 .

I have updated the kernel image on this branch, as well as the metapackage tracking 4.14.151-grsec-securedrop for further QA/testing

@emkll
Add kernel packages for 4.14.152-grsec-securedrop
824edd4 
Also includes kernel metapackage including changes to kernel commandline option for efi support
@emkll emkll force-pushed the sd-core-4.14.150-kernels branch from f46ba5d to 824edd4 Compare November 7, 2019 20:00
@emkll emkll changed the title [WIP] Adds 4.14.150 kernel image package and metapackage Adds 4.14.150 kernel image package and metapackage Nov 7, 2019
@emkll
Copy link
Contributor Author

emkll commented Nov 7, 2019

This is now ready for review. This should only be merged once we are ready to review/merge freedomofpress/securedrop#4962 , as CI will fail until freedomofpress/securedrop#4962 is merged, once this PR is merged.

@conorsch conorsch self-requested a review November 12, 2019 18:55
conorsch
conorsch approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will follow-up with prompt rebase/review of freedomofpress/securedrop#4962 to minimize CI breakage.

@conorsch conorsch merged commit dabffe1 into master Nov 12, 2019
@conorsch conorsch mentioned this pull request Nov 12, 2019
Merged
3 tasks
@conorsch conorsch deleted the sd-core-4.14.150-kernels branch July 9, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emkll @conorsch