Vendor PyMuPDF #940
Merged
Vendor PyMuPDF #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apyrgio
force-pushed
the
2024-09-vendor-pymupdf
branch
from
5f0d4ca to
7a5ce3d
Compare
almet
reviewed
Oct 7, 2024
almet
reviewed
Oct 7, 2024
almet
reviewed
Oct 7, 2024
almet
reviewed
Oct 7, 2024
apyrgio
commented
Oct 7, 2024
apyrgio
force-pushed
the
2024-09-vendor-pymupdf
branch
from
09f00d9 to
6fd0f92
Compare
almet
reviewed
Oct 8, 2024
The PyMuPDF wheels for version 1.24.11 have changed the way they are being built, which means we have to adapt our Dockerfile in order to install them properly.
Install pip in dev environments, so that we can use it to vendor PyMuPDf in subsequent commits.
Add a script that installs PyMuPDF under ./dangerzone/vendor. This will be useful in subsequent commits, for vendoring PyMuPDF when building Debian packages.
apyrgio
force-pushed
the
2024-09-vendor-pymupdf
branch
from
68c516f to
f4073ff
Compare
|
I have rebased on top of the latest |
Prefer importing packages from ./dangerzone/vendor, if there is one there, instead of using the system ones.
Install PyMuPDF under ./dangerzone/vendor, right before we build the .deb package. We vendor PyMuPDF just for Debian, since the provided versions don't have OCR support enabled. Currently, we don't use PyMuPDf on the host, but this will change once we fully implement the on-host conversion feature. Refs #625
apyrgio
force-pushed
the
2024-09-vendor-pymupdf
branch
from
f4073ff to
1eff145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows our build scripts to:
dangerzone/vendor) so that it can be used by Dangerzone in a subsequent PR (see Perform on-host conversion for the pixels to PDF stage #748)Refs #625