acpi_gpiobus: assume GPIO_PIN_INPUT for interrupt pins #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different drivers respond differently to having neither GPIO_PIN_INPUT or GPIO_PIN_OUTPUT set, this stops the unpredictable results.
|
Well what does Linux do for dodgy ACPI tables? We should follow whatever they do if we want the best chance of working. |
|
They seem to be doing the same: https://github.com/torvalds/linux/blob/eabcdba/drivers/gpio/gpiolib-acpi.c#L292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most drivers do nothing when neither GPIO_PIN_INPUT or GPIO_PIN_OUTPUT are set. However, some return
EINVALwhile others (bytgpio is the only example I could find of this) give bad flags to the GPIO controller.In the case of bytgpio, it causes both the input and output of the GPIO pin to be disabled which the controller doesn't seem to like as it causes the entire machine to lose power shortly after.
To fix this, simply assume GPIO_PIN_INPUT for interrupt pins.
I'll CC everyone from the original revision where this change was suggested (see 0ffd7d4)
CC @zxombie @jrtc27 @cperciva