Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add powered by #1093

Merged
merged 4 commits into from
Jan 27, 2025
Merged

feat: add powered by #1093

merged 4 commits into from
Jan 27, 2025

Conversation

ahmaxed
Copy link
Member

@ahmaxed ahmaxed commented Jan 24, 2025

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

@ahmaxed ahmaxed requested a review from a team as a code owner January 24, 2025 07:39
scissorsneedfoodtoo
scissorsneedfoodtoo reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ahmaxed, I took a look and everything LGTM. I just have a couple of minor suggestions since only the English publication is up on Hashnode, so we can just add the link for those builds.

scissorsneedfoodtoo
scissorsneedfoodtoo approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything LGTM 👍

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 5005fac into main Jan 27, 2025
17 checks passed
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the feat/add-poweredby branch January 27, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scissorsneedfoodtoo scissorsneedfoodtoo scissorsneedfoodtoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmaxed @scissorsneedfoodtoo