-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enzyme documentation #882
Conversation
@Thibaut There are a couple of PRs out there that I would love to see available on devdocs.io. Some of them have been around since Oct. 2018 (this one). I was just curious if there is anything that's holding these back from being merged. I'm assuming time is the primary reason 😄 I absolutely love devdocs.io and thanks for all the awesome work! |
Yup, time it is. Thibaut is almost done with moving everything DevDocs related over to freeCodeCamp. As far as I know, the last things to do at the moment are moving over all accounts from different services (Sentry, Heroku etc.) to freeCodeCamp and giving permissions for merging/deploying to the correct people. Besides that, freeCodeCamp has hired @ahmadabdolsaheb to work on DevDocs full-time, and both @j-f1 and myself will receive the permissions to review (and possibly merge/deploy). This should speed up the PR process a lot, since it would mean Thibaut is no longer required to make time to review/merge/deploy contributions. Although I can't say for certain when the move will be completed, I am hoping for it to be done by the end of this month. |
freeCodeCamp has all the accounts now. They're ramping up on the code and deploy process. |
Any updates on getting this merged? Thanks! |
The freeCodeCamp folks are working on something to do with their main product, but they’ll be putting more time into this once that’s done. |
We’re still waiting on the freeCodeCamp folks at the moment. |
The plan is to get the non-scraper PR's merged and deployed asap (basically all PR's labeled improvement and feature). We require one review per PR, and I'll get my reviews on PR's that are not mine done by the end of this week (got to do some performance testing on #714 and check if #724 is correct). I don't know the status of @j-f1 reviewing my PR's. After those "minor" (mostly minor) PR's are merged we can get started with the scraper PR's, which take a bit more work to merge and deploy correctly.
PR's and feature requests are always welcome ofcourse, although it might take a while for it to get merged. As far as adding new maintainers to the project goes, I think it's not wise to add new maintainers until we've solved the PR backlog that we have at the moment.
True to some degree, although I think the best thing to do right now is review all PR's that need to be deployed first, instead of waiting on @QuincyLarson for S3 and Heroku related permissions/accounts. After we got the PR's lined up, it shouldn't be much work for Quincy to provide us the accounts that we need to have access to in order to deploy. |
Add Enzyme documentation
Added a scraper for the Enzyme documentation (Trello card).
The documentation is licensed under the MIT license.
Enzyme doesn't have a logo, so the default icon should be used.