-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding influxdb documentation #348
Conversation
Hi
The way you did it is perfect.
It's OK to leave it in.
Why don't we scrape all 4 docs under one doc/scraper? Seems they all go together + it'd make things easier to maintain & to toggle on/off in the app.
👍
❤️ I have a few other PRs & updates to do before I can look into this one. ETA 3-4 weeks. |
@Thibaut you are suggesting to do something like this:
If this is what you want, I don't agree with this because those are different products, you might use only InfluxDB + Telegraf and want to disable Kapacitor. |
Yes, except we can still break up the categories (types) of each doc, instead of grouping all entries under "InfluxDB", "Kapacitor", etc. Either that or we only add InfluxDB. The other projects are not very popular on GitHub and I'd rather not overload the UI with 3 separate docs — all owned by the same commercial entity. |
Ok, How can implement this? how can I return parent type in EntriesFilter? By the way, I believe that devdocs should add for each scrapper some kind of category, so we can distinct between "DB"/"Language"/"Frameworks"/etc so the ui won't be overloaded. |
Types can't be nested more than one level. But in
This is being tracked in #4. Unfortunately it's not as easy as it sounds and not on my short-term roadmap at the moment. |
@Thibaut do you wanted something like this: 65f9405 If so, I will fix the scrapper to handle all documentations (chrono, kapacitor, telegraf and influxdb). But it will be nice to have some "type hierarchy" like this:
|
Yes. The Chef scraper is done in a similar way: http://devdocs.io/chef/ (Chef Client + Chef Server combined)
Agreed but IMO this would add too much complexity throughout the app, for a small benefit. I'd prefer keeping things simple, unless there's a clear benefit to a majority of users (or docs). |
@Thibaut what is the status of this pull request? are you waiting for me to implement something? |
@yosiat The process for getting this out isn't as simple as clicking the merge button. I'm working my way through https://github.com/Thibaut/devdocs/pulls and will look into yours as soon as I can. In the meantime please squash your commits. |
Hi,
I have added documentation to influxdb, I have some open questions/ideas:
This documentation is open source. See a typo? Please, open an issue.
I think it will be nice to add to the attribution, what do you think?
That's it :)
BTW - I REALLY LOVE DEVDOCS, IT MAKES MY LIFE EASIER 👍