Satisfactory check #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…also be satisfactory.
frederikja163
requested changes
Oct 8, 2024
| /// </summary> | ||
| /// <param name="board"></param> | ||
| /// <returns>True if the board can be solved without trial and error guessing.</returns> | ||
| public static bool IsSatisfactory(Board board) // Certain methods for eliminating candidates using inference are not currently implemented. Implementing them would make this function more acurate. |
Collaborator
Author
There was a problem hiding this comment.
Satisfactory means you can get the solutions without guess-work. Proper is when there is only one solution.
Owner
There was a problem hiding this comment.
As we discussed in the report both of those actually mean the same thing. If you dont need guess work you can always arrive at the single solution. The only time you would ever need guess work is if there is more than one solution.
Collaborator
Author
There was a problem hiding this comment.
A sudoku with a single solution does not have to be satisfactory. It depends how you define satisfactory. How much inference is enough to make it unsatisfactory? I feel like using this method as a qualifier for satisfaction is fine, since the IsProper method is separate anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Solver.IsSatisfactory and tests.
Also moved the success condition in SolveRec to happen earlier.
Also changed SolverTests by moving the easy board creation to its' own function, and making it satisfactory.