Adapt test as IDs are now validated; do not force string casting for …

…untyped fields
freakboy3742 · Sep 14, 2023 · 39905aa · 39905aa
1 parent 501d600
commit 39905aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/xero/basemanager.py b/src/xero/basemanager.py
@@ -439,7 +439,7 @@ def get_filter_value(key, value, value_type=None):
                         value.hex if type(value) == UUID else UUID(value).hex
                     )
                 else:
-                    return "%s" % str(value)
+                    return value
 
             def get_filter_params(key, value):
                 last_key = key.split("_")[-1]

diff --git a/tests/test_manager.py b/tests/test_manager.py
@@ -226,13 +226,18 @@ def test_filter_ids(self):
         manager = Manager("contacts", credentials)
 
         uri, params, method, body, headers, singleobject = manager._filter(
-            IDs=["1", "2", "3", "4", "5"]
+            IDs=[
+                "3e776c4b-ea9e-4bb1-96be-6b0c7a71a37f",
+                "12345678901234567890123456789012",
+            ]
         )
 
         self.assertEqual(method, "get")
         self.assertFalse(singleobject)
 
-        expected_params = {"IDs": "1,2,3,4,5"}
+        expected_params = {
+            "IDs": "3e776c4bea9e4bb196be6b0c7a71a37f,12345678901234567890123456789012"
+        }
         self.assertEqual(params, expected_params)
 
     def test_rawfilter(self):