Merging develop into version-3#633
Merged
Merged
Conversation
- Drop get_download_pdf_url helper; build the URL in JS from doc.route.
- Slim download_pdf: remove unused print_format/language params and the
defensive save/restore around ignore_print_permissions.
- Reduce before_print to one line; have the print template read
doc.get_wiki_space() and doc.get_formatted("modified") directly.
- Extract download_action_item macro and replace two ~20-line copies in
document.html's mobile and desktop dropdowns.
- Drop the Content-Disposition regex; derive filename from doc.route.
- Print format: "Downloaded At" -> "Last Updated"; clear forced "en".
- Revert unrelated drive-by changes to wiki_settings.js/json.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
feat: add wiki document PDF downloads
- Keep the actions dropdown open while the PDF is being prepared so the loading spinner stays visible; close it after the download settles. - Read the route from window.location.pathname on every click instead of caching doc.route at Alpine init — SPA navigation updates the URL via history.pushState, so this stays in sync with the visible page. - Print format: show the full breadcrumb (space › group › subgroup) in the header eyebrow, not just the space name. - Style blockquotes in the PDF to match the public-facing prose: italic, thicker left rule, and open/close quote marks on the first/last paragraph. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Frappe's print CSS pulls in Bootstrap, which sets `blockquote { padding:
10px 20px; font-size: 17.5px }` and `@media print { blockquote { border:
1px solid #999 } }`. Our `border-left` shorthand only overrode the left
side, so the top/right/bottom borders and extra padding leaked through —
the PDF showed a fully-boxed quote with vertical air around the text
instead of the public site's simple left-rule treatment.
Explicitly zero the border and padding before re-applying the left rule.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix: wiki pdf download misc fixes
Mirror the public-page callout treatment in the print format so note/tip/caution/danger callouts render with their colored backgrounds and tinted icons instead of plain icon + text. While doing this, inline every `var(--...)` reference as a hex value: wkhtmltopdf's QtWebKit predates CSS Custom Properties, so all our existing `var(--gray-*)` declarations were silently dropping too — the header divider, table borders, blockquote rule, and eyebrow colors weren't rendering either, not just the new callout colors. Layout note: the public CSS uses `display: grid` with `grid-template-columns: auto 1fr`; QtWebKit doesn't support Grid, so the print format floats the icon left and gives `.callout-body` its own block formatting context via `overflow: hidden`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix: style callouts in wiki PDF download
fix(wiki): order feedback reactions bad -> good
fix: prevent indexing wiki app routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.